linux-kernel - Re: [PATCH 32/87] usb: pvrusb2: replace kmalloc and memset with kzalloc in pvrusb2-eeprom.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1906272244210.22929@lochley.isely.net>
Date:   Thu, 27 Jun 2019 22:44:45 -0500 (CDT)
From:   isely@...ly.net
To:     Fuqian Huang <huangfq.daxian@...il.com>
cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Mike Isely at pobox <isely@...ox.com>
Subject: Re: [PATCH 32/87] usb: pvrusb2: replace kmalloc and memset with
 kzalloc in pvrusb2-eeprom.c


Acked-by: Mike Isely <isely@...ox.com>

  -Mike

On Fri, 28 Jun 2019, Fuqian Huang wrote:

> kmalloc + memset(0) -> kzalloc
> 
> Signed-off-by: Fuqian Huang <huangfq.daxian@...il.com>
> ---
>  drivers/media/usb/pvrusb2/pvrusb2-eeprom.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/media/usb/pvrusb2/pvrusb2-eeprom.c b/drivers/media/usb/pvrusb2/pvrusb2-eeprom.c
> index 79f0e0c6df37..fac90af8b537 100644
> --- a/drivers/media/usb/pvrusb2/pvrusb2-eeprom.c
> +++ b/drivers/media/usb/pvrusb2/pvrusb2-eeprom.c
> @@ -39,7 +39,7 @@ static u8 *pvr2_eeprom_fetch(struct pvr2_hdw *hdw)
>  	int ret;
>  	int mode16 = 0;
>  	unsigned pcnt,tcnt;
> -	eeprom = kmalloc(EEPROM_SIZE,GFP_KERNEL);
> +	eeprom = kzalloc(EEPROM_SIZE,GFP_KERNEL);
>  	if (!eeprom) {
>  		pvr2_trace(PVR2_TRACE_ERROR_LEGS,
>  			   "Failed to allocate memory required to read eeprom");
> @@ -74,7 +74,6 @@ static u8 *pvr2_eeprom_fetch(struct pvr2_hdw *hdw)
>  	   (1) we're only fetching part of the eeprom, and (2) if we were
>  	   getting the whole thing our I2C driver can't grab it in one
>  	   pass - which is what tveeprom is otherwise going to attempt */
> -	memset(eeprom,0,EEPROM_SIZE);
>  	for (tcnt = 0; tcnt < EEPROM_SIZE; tcnt += pcnt) {
>  		pcnt = 16;
>  		if (pcnt + tcnt > EEPROM_SIZE) pcnt = EEPROM_SIZE-tcnt;
> 

-- 

Mike Isely
isely @ isely (dot) net
PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8