linux-kernel - Re: [RESEND PATCH 05/10] crypto: sha256_generic: Export the Transform function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190628050944.GE673@sol.localdomain>
Date:   Thu, 27 Jun 2019 22:09:44 -0700
From:   Eric Biggers <ebiggers@...nel.org>
To:     Keerthy <j-keerthy@...com>
Cc:     herbert@...dor.apana.org.au, davem@...emloft.net,
        robh+dt@...nel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        t-kristo@...com, linux-crypto@...r.kernel.org, nm@...com
Subject: Re: [RESEND PATCH 05/10] crypto: sha256_generic: Export the
 Transform function

On Fri, Jun 28, 2019 at 09:57:40AM +0530, Keerthy wrote:
> The transform function can be used as is by other crypto
> drivers that need to transform the 256 bit key using cpu.
> Hence export it.

What is this supposed to mean?  SHA-256 is an unkeyed hash function.

Also, you need to actually explain why this is needed.  If your hardware
supports SHA-256, why do you need to use the C sha256_transform()?

- Eric