linux-kernel - Re: [PATCH RFC] mtd: ubi: Add fastmap sysfs attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <455367016.19242.1561704508169.JavaMail.zimbra@nod.at>
Date:   Fri, 28 Jun 2019 08:48:28 +0200 (CEST)
From:   Richard Weinberger <richard@....at>
To:     chengzhihao1@...wei.com
Cc:     david oberhollenzer <david.oberhollenzer@...ma-star.at>,
        david <david@...ma-star.at>,
        boris brezillon <boris.brezillon@...e-electrons.com>,
        yi zhang <yi.zhang@...wei.com>,
        linux-mtd <linux-mtd@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFC] mtd: ubi: Add fastmap sysfs attribute

Zhihao Cheng,

----- Ursprüngliche Mail -----
> +	else if (attr == &dev_fastmap)
> +		ret = sprintf(buf, "%d\n", ubi->fm ? 1 : 0);
> 	else

I fear this is not correct. ubi->fm is an internal data structure
of UBI.
UBI sets it to NULL while it updates fastmap, and updates it later.
So userspace would see false negatives.

Thanks,
//richard