linux-kernel - Re: [PATCH v4] mtd: spi-nor: fix nor->addr_width when its value configured from SFDP does not match the actual width

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <32340066-402a-0067-8694-91e34e7a7480@microchip.com>
Date:   Fri, 28 Jun 2019 08:20:54 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <vigneshr@...com>, <liu.xiang6@....com.cn>,
        <linux-mtd@...ts.infradead.org>
CC:     <richard@....at>, <liuxiang_1999@....com>,
        <linux-kernel@...r.kernel.org>, <marek.vasut@...il.com>,
        <miquel.raynal@...tlin.com>, <computersforpeace@...il.com>,
        <dwmw2@...radead.org>
Subject: Re: [PATCH v4] mtd: spi-nor: fix nor->addr_width when its value
 configured from SFDP does not match the actual width



On 06/27/2019 04:23 PM, Vignesh Raghavendra wrote:
> External E-Mail
> 
> 
> 
> On 24/06/19 9:30 PM, Liu Xiang wrote:
>> IS25LP256 gets BFPT_DWORD1_ADDRESS_BYTES_3_ONLY from BFPT table for
>> address width. But in actual fact the flash can support 4-byte address.
>> Use a post bfpt fixup hook to overwrite the address width advertised by
>> the BFPT.
>>
>> Suggested-by: Tudor Ambarus <tudor.ambarus@...rochip.com>

dropped Suggested-by tag, you can't add this tag for each change request. You
should add it only when someone gives you the general idea on how to do the patch.

>> Signed-off-by: Liu Xiang <liu.xiang6@....com.cn>
>>
> 
> Reviewed-by: Vignesh Raghavendra <vigneshr@...com>
> 
> Regards
> Vignesh
> 
>> ---
>>
>> Changes in v4:
>>  update the comment suggested by Tudor.
>> ---
>>  drivers/mtd/spi-nor/spi-nor.c | 25 ++++++++++++++++++++++++-
>>  1 file changed, 24 insertions(+), 1 deletion(-)
>>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git,
spi-nor/next branch.

Thanks,
ta