linux-kernel - Re: [PATCH] ALSA: usb-audio: fix sign unintended sign extension on left shifts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hwoh66r6j.wl-tiwai@suse.de>
Date:   Fri, 28 Jun 2019 10:37:56 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Colin King" <colin.king@...onical.com>
Cc:     <alsa-devel@...a-project.org>, "Jaroslav Kysela" <perex@...ex.cz>,
        <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: usb-audio: fix sign unintended sign extension on left shifts

On Thu, 27 Jun 2019 18:43:08 +0200,
Colin King wrote:
> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> There are a couple of left shifts of unsigned 8 bit values that
> first get promoted to signed ints and hence get sign extended
> on the shift if the top bit of the 8 bit values are set. Fix
> this by casting the 8 bit values to unsigned ints to stop the
> unintentional sign extension.
> 
> Addresses-Coverity: ("Unintended sign extension")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied now.  Thanks.


Takashi