[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190628104907.vign7lmgftrwfisv@sirius.home.kraxel.org>
Date: Fri, 28 Jun 2019 12:49:07 +0200
From: Gerd Hoffmann <kraxel@...hat.com>
To: Chia-I Wu <olvaffe@...il.com>
Cc: ML dri-devel <dri-devel@...ts.freedesktop.org>,
David Airlie <airlied@...ux.ie>,
"open list:VIRTIO GPU DRIVER"
<virtualization@...ts.linux-foundation.org>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 11/12] drm/virtio: switch from ttm to gem shmem helpers
> > static inline struct virtio_gpu_object*
> > virtio_gpu_object_ref(struct virtio_gpu_object *bo)
> The last users of these two helpers are removed with this patch. We
> can remove them.
patch 12/12 does that.
> > + bo = gem_to_virtio_gpu_obj(&shmem_obj->base);
> > + bo->base.base.funcs = &virtio_gpu_gem_funcs;
> Move this to virtio_gpu_create_object.
Fixed.
> > + ret = drm_gem_shmem_pin(&obj->base.base);
> The bo is attached for its entire lifetime, at least currently. Maybe
> we can use drm_gem_shmem_get_pages_sgt (and get rid of obj->pages).
Already checked this.
We can't due to the iommu quirks.
cheers,
Gerd
Powered by blists - more mailing lists