linux-kernel - Re: [PATCH] platform/chrome: lightbar: Get drvdata from parent in suspend/resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b34fb026-7924-204c-99ed-7e2a5a8ebc87@collabora.com>
Date:   Fri, 28 Jun 2019 12:50:08 +0200
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Rajat Jain <rajatja@...gle.com>,
        Benson Leung <bleung@...omium.org>,
        Guenter Roeck <groeck@...omium.org>,
        linux-kernel@...r.kernel.org, rajatxjain@...il.com,
        evgreen@...gle.com, gwendal@...gle.com
Subject: Re: [PATCH] platform/chrome: lightbar: Get drvdata from parent in
 suspend/resume



On 27/6/19 23:47, Rajat Jain wrote:
> The lightbar driver never assigned the drvdata in probe method, and
> thus there is nothing there. Need to get the ec_dev from the parent's
> drvdata.
> 
> Signed-off-by: Rajat Jain <rajatja@...gle.com>

Queued for 5.3

Thanks,
~ Enric

> ---
>  drivers/platform/chrome/cros_ec_lightbar.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/chrome/cros_ec_lightbar.c b/drivers/platform/chrome/cros_ec_lightbar.c
> index d30a6650b0b5..26117a8991b3 100644
> --- a/drivers/platform/chrome/cros_ec_lightbar.c
> +++ b/drivers/platform/chrome/cros_ec_lightbar.c
> @@ -600,7 +600,7 @@ static int cros_ec_lightbar_remove(struct platform_device *pd)
>  
>  static int __maybe_unused cros_ec_lightbar_resume(struct device *dev)
>  {
> -	struct cros_ec_dev *ec_dev = dev_get_drvdata(dev);
> +	struct cros_ec_dev *ec_dev = dev_get_drvdata(dev->parent);
>  
>  	if (userspace_control)
>  		return 0;
> @@ -610,7 +610,7 @@ static int __maybe_unused cros_ec_lightbar_resume(struct device *dev)
>  
>  static int __maybe_unused cros_ec_lightbar_suspend(struct device *dev)
>  {
> -	struct cros_ec_dev *ec_dev = dev_get_drvdata(dev);
> +	struct cros_ec_dev *ec_dev = dev_get_drvdata(dev->parent);
>  
>  	if (userspace_control)
>  		return 0;
>