linux-kernel - Re: [Linux-kernel-mentees][PATCH v2] nl80211: Fix undefined behavior in bit shift

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b5a247aa3bb21094c0a6ef1d8e3281d701bb6200.camel@sipsolutions.net>
Date:   Fri, 28 Jun 2019 17:17:30 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Shuah Khan <skhan@...uxfoundation.org>,
        Jiunn Chang <c0d1n61at3@...il.com>
Cc:     linux-kernel-mentees@...ts.linuxfoundation.org,
        linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [Linux-kernel-mentees][PATCH v2] nl80211: Fix undefined
 behavior in bit shift

Hi Shuah,

> I went looking in the git log. Looks like there are several commits with
> "Changes since" included in the commit log. It still appears to be
> maintainer preference. Probably from networking and networking related
> areas - wireless being one of them. This trend is recent it appears in
> any case.

Yeah. I was really just observing that I'd seen this, and some people (I
guess 'many' was an exaggeration) actively request it to be in the
commit log. I "grew up" with "changelog after ---" too ;-)

> There is a value to seeing changes as the work evolves. However, there
> is the concern that how log should it be.

That doesn't parse, what did you mean?

> This example commit has history from RFC stage and no doubt very useful
> since this is a new driver.
> 
> 8ef988b914bd449458eb2174febb67b0f137b33c
> 
> If we make this more of a norm, we do want to make sure, we evolve
> from informal nature of these "Changes since", to "Commit log" text.

Not sure it's really worth it, but I guess some recommendations could be
useful. If it is indeed to become the norm, and there aren't some people
who strongly feel it should *not* be included.

johannes