linux-kernel - Re: [PATCH] USB: serial: ftdi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190628151543.GO508@localhost>
Date:   Fri, 28 Jun 2019 17:15:43 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Andreas Fritiofson <andreas.fritiofson@...o.com>
Cc:     Johan Hovold <johan@...nel.org>, linux-usb@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: serial: ftdi_sio: add ID for isodebug v1

On Fri, Jun 28, 2019 at 03:08:34PM +0200, Andreas Fritiofson wrote:
> This adds the vid:pid of the isodebug v1 isolated JTAG/SWD+UART. Only the
> second channel is available for use as a serial port.
> 
> Signed-off-by: Andreas Fritiofson <andreas.fritiofson@...o.com>
> ---
>  drivers/usb/serial/ftdi_sio.c     | 1 +
>  drivers/usb/serial/ftdi_sio_ids.h | 6 ++++++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
> index 8f5b17471..ba74c2ad6 100644
> --- a/drivers/usb/serial/ftdi_sio.c
> +++ b/drivers/usb/serial/ftdi_sio.c
> @@ -1027,6 +1027,7 @@ static const struct usb_device_id id_table_combined[] = {
>  	{ USB_DEVICE(AIRBUS_DS_VID, AIRBUS_DS_P8GR) },
>  	/* EZPrototypes devices */
>  	{ USB_DEVICE(EZPROTOTYPES_VID, HJELMSLUND_USB485_ISO_PID) },
> +	{ USB_DEVICE_INTERFACE_NUMBER(UNJO_VID, ISODEBUG_V1_PID, 1) },
>  	{ }					/* Terminating entry */
>  };
>  
> diff --git a/drivers/usb/serial/ftdi_sio_ids.h b/drivers/usb/serial/ftdi_sio_ids.h
> index b863bedb5..5c681f494 100644
> --- a/drivers/usb/serial/ftdi_sio_ids.h
> +++ b/drivers/usb/serial/ftdi_sio_ids.h
> @@ -1541,3 +1541,9 @@
>  #define CHETCO_SEASMART_DISPLAY_PID	0xA5AD /* SeaSmart NMEA2000 Display */
>  #define CHETCO_SEASMART_LITE_PID	0xA5AE /* SeaSmart Lite USB Adapter */
>  #define CHETCO_SEASMART_ANALOG_PID	0xA5AF /* SeaSmart Analog Adapter */
> +
> +/*
> + * Unjo AB
> + */
> +#define UNJO_VID			0x22B7
> +#define ISODEBUG_V1_PID			0x150D

I added an UNJO_ prefix to the PID define since I assume this is your
product (named ISODEBUG).

Now applied, thanks.

Johan