linux-kernel - Re: linux-next: build failure after merge of the battery tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190628153146.c2lh4y55qvcmqhry@earth.universe>
Date:   Fri, 28 Jun 2019 17:31:46 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Nick Crews <ncrews@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>
Subject: Re: linux-next: build failure after merge of the battery tree

Hi,

On Fri, Jun 28, 2019 at 02:03:04PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the battery tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/power/supply/wilco-charger.c: In function 'wilco_charge_get_property':
> drivers/power/supply/wilco-charger.c:104:8: error: implicit declaration of function 'wilco_ec_get_byte_property'; did you mean 'wilco_charge_get_property'? [-Werror=implicit-function-declaration]
>   ret = wilco_ec_get_byte_property(ec, property_id, &raw);
>         ^~~~~~~~~~~~~~~~~~~~~~~~~~
>         wilco_charge_get_property
> drivers/power/supply/wilco-charger.c: In function 'wilco_charge_set_property':
> drivers/power/supply/wilco-charger.c:130:10: error: implicit declaration of function 'wilco_ec_set_byte_property'; did you mean 'wilco_charge_set_property'? [-Werror=implicit-function-declaration]
>    return wilco_ec_set_byte_property(ec, PID_CHARGE_MODE, mode);
>           ^~~~~~~~~~~~~~~~~~~~~~~~~~
>           wilco_charge_set_property
> 
> Caused by commit
> 
>   0736343e4c56 ("power_supply: wilco_ec: Add charging config driver")
> 
> I have reverted that commit for today.

Oops, thanks for the hint. I did not notice this with ARM
allmodconfig. I dropped the patch for this cycle.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)