linux-kernel - [PATCH 09/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20190629103654.GA15592@hari-Inspiron-1545>
Date:   Sat, 29 Jun 2019 16:06:54 +0530
From:   Hariprasad Kelam <hariprasad.kelam@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Payal Kshirsagar <payal.s.kshirsagar.98@...il.com>,
        Hariprasad Kelam <hariprasad.kelam@...il.com>,
        Himadri Pandya <himadri18.07@...il.com>,
        Puranjay Mohan <puranjay12@...il.com>,
        Colin Ian King <colin.king@...onical.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: [PATCH 09/10] staging/rtl8723bs/hal: fix comparison to true/false is
 error prone

fix below issues reported by checkpatch

CHECK: Using comparison to false is error prone
CHECK: Using comparison to true is error prone

Signed-off-by: Hariprasad Kelam <hariprasad.kelam@...il.com>
---
 drivers/staging/rtl8723bs/hal/hal_com.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c
index 2763479..d3025ca 100644
--- a/drivers/staging/rtl8723bs/hal/hal_com.c
+++ b/drivers/staging/rtl8723bs/hal/hal_com.c
@@ -140,7 +140,7 @@ u8 hal_com_config_channel_plan(
 	}
 
 	if (
-		(false == pHalData->bDisableSWChannelPlan) &&
+		(!pHalData->bDisableSWChannelPlan) &&
 		rtw_is_channel_plan_valid(sw_channel_plan)
 	)
 		chnlPlan = sw_channel_plan;
-- 
2.7.4