linux-kernel - Re: [PATCH 07/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190629104011.GA15715@hari-Inspiron-1545>
Date:   Sat, 29 Jun 2019 16:10:11 +0530
From:   Hariprasad Kelam <hariprasad.kelam@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 07/10] staging/rtl8723bs/hal: fix comparison to
 true/false is error prone

On Sat, Jun 29, 2019 at 03:57:22PM +0530, Hariprasad Kelam wrote:

Please ignore this patch
> fix below issues reported by checkpatch
> 
> CHECK: Using comparison to false is error prone
> CHECK: Using comparison to true is error prone
> 
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@...il.com>
> ---
>  drivers/staging/rtl8723bs/hal/odm_CfoTracking.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c b/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c
> index a733046..7883b26 100644
> --- a/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c
> +++ b/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c
> @@ -221,7 +221,7 @@ void ODM_CfoTracking(void *pDM_VOID)
>  		pCfoTrack->CFO_ave_pre = CFO_ave;
>  
>  		/* 4 1.4 Dynamic Xtal threshold */
> -		if (pCfoTrack->bAdjust == false) {
> +		if (!pCfoTrack->bAdjust) {
>  			if (CFO_ave > CFO_TH_XTAL_HIGH || CFO_ave < (-CFO_TH_XTAL_HIGH))
>  				pCfoTrack->bAdjust = true;
>  		} else {
> -- 
> 2.7.4
>