linux-kernel - Re: [PATCH v2 08/27] i2c: busses: remove memset after dmam_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 29 Jun 2019 13:12:01 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Jarkko Nikula <jarkko.nikula@...ux.intel.com>
Cc:     Fuqian Huang <huangfq.daxian@...il.com>,
        Seth Heasley <seth.heasley@...el.com>,
        Neil Horman <nhorman@...driver.com>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 08/27] i2c: busses: remove memset after
 dmam_alloc_coherent

On Fri, Jun 28, 2019 at 09:22:31AM +0300, Jarkko Nikula wrote:
> Hi
> 
> On 6/28/19 5:47 AM, Fuqian Huang wrote:
> > In commit af7ddd8a627c
> > ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
> > dmam_alloc_coherent has already zeroed the memory.
> > So memset is not needed.
> > 
> > Signed-off-by: Fuqian Huang <huangfq.daxian@...il.com>
> > ---
> >   drivers/i2c/busses/i2c-ismt.c | 2 --
> >   1 file changed, 2 deletions(-)
> > 
> It would be better to refer actual commit or commits that implement that
> zeroing rather than merge point in commit log if possible.
> 
> At quick look commit 518a2f1925c3 ("dma-mapping: zero memory returned from
> dma_alloc_*") is the one but I'm not really an expert here to say is that
> alone enough.

Fuqian, can you clarify if the commit pointed by Jarkko is enough as a
reference or if it really needs the merge tag?

Also, please include the tags you collected in v1 when sending v2 (and
there was no significant code change).


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)