linux-kernel - Re: [PATCH] intel_menlow: avoid null pointer deference error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 29 Jun 2019 16:17:01 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Young Xiao <92siuyang@...il.com>
Cc:     Sujith Thomas <sujith.thomas@...el.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] intel_menlow: avoid null pointer deference error

On Wed, May 29, 2019 at 4:55 AM Young Xiao <92siuyang@...il.com> wrote:
>
> Fix a null pointer deference by acpi_driver_data() if device is
> null (dereference before check). We should only set cdev and check
> this is OK after we are sure device is not null.
>

Pushed to my review and testing queue, thanks!

> Signed-off-by: Young Xiao <92siuyang@...il.com>
> ---
>  drivers/platform/x86/intel_menlow.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/intel_menlow.c b/drivers/platform/x86/intel_menlow.c
> index 77eb870..28feb5c 100644
> --- a/drivers/platform/x86/intel_menlow.c
> +++ b/drivers/platform/x86/intel_menlow.c
> @@ -180,9 +180,13 @@ static int intel_menlow_memory_add(struct acpi_device *device)
>
>  static int intel_menlow_memory_remove(struct acpi_device *device)
>  {
> -       struct thermal_cooling_device *cdev = acpi_driver_data(device);
> +       struct thermal_cooling_device *cdev;
> +
> +       if (!device)
> +               return -EINVAL;
>
> -       if (!device || !cdev)
> +       cdev = acpi_driver_data(device);
> +       if (!cdev)
>                 return -EINVAL;
>
>         sysfs_remove_link(&device->dev.kobj, "thermal_cooling");
> --
> 2.7.4
>


-- 
With Best Regards,
Andy Shevchenko