lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 29 Jun 2019 07:50:09 -0700 From: Guenter Roeck <linux@...ck-us.net> To: Anshuman Khandual <anshuman.khandual@....com> Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org, Mark Rutland <mark.rutland@....com>, Michal Hocko <mhocko@...e.com>, linux-ia64@...r.kernel.org, linux-sh@...r.kernel.org, Peter Zijlstra <peterz@...radead.org>, Catalin Marinas <catalin.marinas@....com>, Dave Hansen <dave.hansen@...ux.intel.com>, Will Deacon <will.deacon@....com>, Paul Mackerras <paulus@...ba.org>, sparclinux@...r.kernel.org, Stephen Rothwell <sfr@...b.auug.org.au>, linux-s390@...r.kernel.org, Yoshinori Sato <ysato@...rs.sourceforge.jp>, Michael Ellerman <mpe@...erman.id.au>, x86@...nel.org, Russell King <linux@...linux.org.uk>, Matthew Wilcox <willy@...radead.org>, Ingo Molnar <mingo@...hat.com>, James Hogan <jhogan@...nel.org>, linux-snps-arc@...ts.infradead.org, Fenghua Yu <fenghua.yu@...el.com>, Andrey Konovalov <andreyknvl@...gle.com>, Andy Lutomirski <luto@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, linux-arm-kernel@...ts.infradead.org, Christophe Leroy <christophe.leroy@....fr>, Tony Luck <tony.luck@...el.com>, Heiko Carstens <heiko.carstens@...ibm.com>, Vineet Gupta <vgupta@...opsys.com>, linux-mips@...r.kernel.org, Ralf Baechle <ralf@...ux-mips.org>, Paul Burton <paul.burton@...s.com>, Martin Schwidefsky <schwidefsky@...ibm.com>, Andrew Morton <akpm@...ux-foundation.org>, linuxppc-dev@...ts.ozlabs.org, "David S. Miller" <davem@...emloft.net> Subject: Re: [PATCH] mm: Generalize and rename notify_page_fault() as kprobe_page_fault() Hi, On Thu, Jun 13, 2019 at 03:37:24PM +0530, Anshuman Khandual wrote: > Architectures which support kprobes have very similar boilerplate around > calling kprobe_fault_handler(). Use a helper function in kprobes.h to unify > them, based on the x86 code. > > This changes the behaviour for other architectures when preemption is > enabled. Previously, they would have disabled preemption while calling the > kprobe handler. However, preemption would be disabled if this fault was > due to a kprobe, so we know the fault was not due to a kprobe handler and > can simply return failure. > > This behaviour was introduced in the commit a980c0ef9f6d ("x86/kprobes: > Refactor kprobes_fault() like kprobe_exceptions_notify()") > With this patch applied, parisc:allmodconfig images no longer build. In file included from arch/parisc/mm/fixmap.c:8: include/linux/kprobes.h: In function 'kprobe_page_fault': include/linux/kprobes.h:477:9: error: implicit declaration of function 'kprobe_fault_handler'; did you mean 'kprobe_page_fault'? Reverting the patch fixes the problem. Guenter
Powered by blists - more mailing lists