linux-kernel - Re: [PATCH] drm/msm: Transition console to msm framebuffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 29 Jun 2019 12:55:59 -0700
From:   Rob Clark <robdclark@...il.com>
To:     Jeffrey Hugo <jeffrey.l.hugo@...il.com>
Cc:     Sean Paul <sean@...rly.run>, David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        freedreno <freedreno@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/msm: Transition console to msm framebuffer

On Sat, Jun 29, 2019 at 10:46 AM Rob Clark <robdclark@...il.com> wrote:
>
> On Fri, Jun 28, 2019 at 9:28 AM Jeffrey Hugo <jeffrey.l.hugo@...il.com> wrote:
> >
> > If booting a device using EFI, efifb will likely come up and claim the
> > console.  When the msm display stack finally comes up, we want the
> > console to move over to the msm fb, so add support to kick out any
> > firmware based framebuffers to accomplish the console transition.
> >
> > Suggested-by: Rob Clark <robdclark@...il.com>
> > Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@...il.com>
>
> lgtm,
>
> Reviewed-by: Rob Clark <robdclark@...il.com>

and I'll also add, on yoga c630,

Tested-by: Rob Clark <robdclark@...il.com>


>
>
> > ---
> >  drivers/gpu/drm/msm/msm_fbdev.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c
> > index 2429d5e6ce9f..e3836c7725a6 100644
> > --- a/drivers/gpu/drm/msm/msm_fbdev.c
> > +++ b/drivers/gpu/drm/msm/msm_fbdev.c
> > @@ -169,6 +169,9 @@ struct drm_fb_helper *msm_fbdev_init(struct drm_device *dev)
> >         if (ret)
> >                 goto fini;
> >
> > +       /* the fw fb could be anywhere in memory */
> > +       drm_fb_helper_remove_conflicting_framebuffers(NULL, "msm", false);
> > +
> >         ret = drm_fb_helper_initial_config(helper, 32);
> >         if (ret)
> >                 goto fini;
> > --
> > 2.17.1
> >