linux-kernel - Re: [PATCH 10/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190630012917.GA21923@t-1000>
Date:   Sat, 29 Jun 2019 18:29:18 -0700
From:   Shobhit Kukreti <shobhitkukreti@...il.com>
To:     Hariprasad Kelam <hariprasad.kelam@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Nishka Dasgupta <nishkadg.linux@...il.com>,
        Himadri Pandya <himadri18.07@...il.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Hardik Singh Rathore <hardiksingh.k@...il.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/10] staging/rtl8723bs/hal: fix comparison to
 true/false is error prone

On Sat, Jun 29, 2019 at 04:07:51PM +0530, Hariprasad Kelam wrote:

Hello Hari Prasad,
Please add the recommended reviewers mentioned in the TODO file of 
rtl8723bs directory.

I see the following emails in the TODO file.

Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Hans de Goede <hdegoede@...hat.com> and Larry Finger
<Larry.Finger@...inger.net>

> fix below issues reported by checkpatch
> 
> CHECK: Using comparison to false is error prone
> CHECK: Using comparison to true is error prone
> 
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@...il.com>
> ---
>  drivers/staging/rtl8723bs/hal/hal_btcoex.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> index 66caf34..99e0b91 100644
> --- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> +++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> @@ -290,7 +290,7 @@ static u8 halbtcoutsrc_IsWifiBusy(struct adapter *padapter)
>  	if (check_fwstate(pmlmepriv, WIFI_ASOC_STATE) == true) {
>  		if (check_fwstate(pmlmepriv, WIFI_AP_STATE) == true)
>  			return true;
> -		if (true == pmlmepriv->LinkDetectInfo.bBusyTraffic)
> +		if (pmlmepriv->LinkDetectInfo.bBusyTraffic)
>  			return true;
>  	}
>  
> @@ -310,12 +310,12 @@ static u32 _halbtcoutsrc_GetWifiLinkStatus(struct adapter *padapter)
>  
>  	if (check_fwstate(pmlmepriv, WIFI_ASOC_STATE) == true) {
>  		if (check_fwstate(pmlmepriv, WIFI_AP_STATE) == true) {
> -			if (true == bp2p)
> +			if (bp2p)
>  				portConnectedStatus |= WIFI_P2P_GO_CONNECTED;
>  			else
>  				portConnectedStatus |= WIFI_AP_CONNECTED;
>  		} else {
> -			if (true == bp2p)
> +			if (bp2p)
>  				portConnectedStatus |= WIFI_P2P_GC_CONNECTED;
>  			else
>  				portConnectedStatus |= WIFI_STA_CONNECTED;
> @@ -372,7 +372,7 @@ static u8 halbtcoutsrc_GetWifiScanAPNum(struct adapter *padapter)
>  
>  	pmlmeext = &padapter->mlmeextpriv;
>  
> -	if (GLBtcWiFiInScanState == false) {
> +	if (!GLBtcWiFiInScanState) {
>  		if (pmlmeext->sitesurvey_res.bss_cnt > 0xFF)
>  			scan_AP_num = 0xFF;
>  		else
> @@ -1444,7 +1444,7 @@ void hal_btcoex_IQKNotify(struct adapter *padapter, u8 state)
>  
>  void hal_btcoex_BtInfoNotify(struct adapter *padapter, u8 length, u8 *tmpBuf)
>  {
> -	if (GLBtcWiFiInIQKState == true)
> +	if (GLBtcWiFiInIQKState)
>  		return;
>  
>  	EXhalbtcoutsrc_BtInfoNotify(&GLBtCoexist, tmpBuf, length);
> -- 
> 2.7.4
>