linux-kernel - Re: [PATCH v2 07/27] gpu: drm: remove memset after zalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACvgo52dW16DahT37aAxF8snZSJo_42ie3M0Le_edF19SBYL0Q@mail.gmail.com>
Date:   Mon, 1 Jul 2019 13:43:16 +0100
From:   Emil Velikov <emil.l.velikov@...il.com>
To:     Fuqian Huang <huangfq.daxian@...il.com>
Cc:     Leo Li <sunpeng.li@....com>, Rex Zhu <rex.zhu@....com>,
        David Airlie <airlied@...ux.ie>,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
        amd-gfx mailing list <amd-gfx@...ts.freedesktop.org>,
        Alex Deucher <alexander.deucher@....com>,
        Huang Rui <ray.huang@....com>,
        ML dri-devel <dri-devel@...ts.freedesktop.org>,
        David Francis <David.Francis@....com>,
        Colin Ian King <colin.king@...onical.com>,
        Evan Quan <evan.quan@....com>,
        Christian König <christian.koenig@....com>
Subject: Re: [PATCH v2 07/27] gpu: drm: remove memset after zalloc

Hi Fuqian,

On Fri, 28 Jun 2019 at 09:30, Fuqian Huang <huangfq.daxian@...il.com> wrote:
>
> zalloc has already zeroed the memory.
> so memset is unneeded.
>
> Signed-off-by: Fuqian Huang <huangfq.daxian@...il.com>
> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c       | 2 --
>  drivers/gpu/drm/amd/powerplay/hwmgr/process_pptables_v1_0.c | 2 --
>  drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c            | 2 --
>  drivers/gpu/drm/amd/powerplay/smumgr/iceland_smumgr.c       | 2 --
>  drivers/gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c         | 2 --
>  5 files changed, 10 deletions(-)
>
Thanks for fixing these. One nit pick: the commit message should start
with "drm/amdgpu:" as you can see from git log.
With that:

Reviewed-by: Emil Velikov <emil.velikov@...labora.com>

-Emil