linux-kernel - Re: [PATCH] Revert "tpm: pass an array of tpm_extend_digest structures to tpm_pcr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190701152159.42f249b5@kitsune.suse.cz>
Date:   Mon, 1 Jul 2019 15:21:59 +0200
From:   Michal Suchánek <msuchanek@...e.de>
To:     linux-integrity@...r.kernel.org
Cc:     Peter Huewe <peterhuewe@....de>,
        Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
        Jason Gunthorpe <jgg@...pe.ca>, Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mimi Zohar <zohar@...ux.ibm.com>,
        Dmitry Kasatkin <dmitry.kasatkin@...il.com>,
        James Morris <jmorris@...ei.org>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        James Bottomley <jejb@...ux.ibm.com>,
        David Howells <dhowells@...hat.com>,
        Roberto Sassu <roberto.sassu@...wei.com>,
        Tomas Winkler <tomas.winkler@...el.com>,
        Armijn Hemel <armijn@...ldur.nl>,
        Stefan Berger <stefanb@...ux.vnet.ibm.com>,
        Jerry Snitselaar <jsnitsel@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org,
        linux-security-module@...r.kernel.org, keyrings@...r.kernel.org
Subject: Re: [PATCH] Revert "tpm: pass an array of tpm_extend_digest
 structures to tpm_pcr_extend()"

On Mon,  1 Jul 2019 15:15:05 +0200
Michal Suchanek <msuchanek@...e.de> wrote:

> This reverts commit 0b6cf6b97b7ef1fa3c7fefab0cac897a1c4a3400 to avoid following crash:
> 
>     BUG: Kernel NULL pointer dereference at 0x00000012
>     Faulting instruction address: 0xc000000000897908
>     Oops: Kernel access of bad area, sig: 11 [#1]
>     LE PAGE_SIZE=64K MMU=Hash SMP NR_CPUS=2048 NUMA pSeries
>     Modules linked in:
>     CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.2.0-rc6-2.gf99f70b-default #1 openSUSE Tumbleweed (unreleased)
>     NIP:  c000000000897908 LR: c000000000897860 CTR: 0000000000000009
>     REGS: c000000004eb7550 TRAP: 0380   Not tainted  (5.2.0-rc6-2.gf99f70b-default)
>     MSR:  800000010280b033 <SF,VEC,VSX,EE,FP,ME,IR,DR,RI,LE,TM[E]>  CR: 88000224  XER: 20040001
>     CFAR: c000000000c4e964 IRQMASK: 0
>     GPR00: c000000000897860 c000000004eb77e0 c0000000015ced00 0000000000000000
>     GPR04: 0000000000000003 0000000000000001 0000000022000000 000000000000000e
>     GPR08: c0000005b46b0000 0000000000010000 0000000000000022 0000000010325476
>     GPR12: 0000000048000222 c0000000019a0000 c000000000010b70 0000000000000000
>     GPR16: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
>     GPR20: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
>     GPR24: c000000000eded00 c0000000014ecb60 c000000000ccedf8 c0000005b5c9d000
>     GPR28: 000000000000000a 0000000000000012 c000000000f01180 c00c0000016d1ac0
>     NIP [c000000000897908] tpm1_pcr_extend+0x118/0x1d0
>     LR [c000000000897860] tpm1_pcr_extend+0x70/0x1d0
>     Call Trace:
>     [c000000004eb77e0] [c000000000897860] tpm1_pcr_extend+0x70/0x1d0 (unreliable)
>     [c000000004eb7890] [c0000000008964e4] tpm_pcr_extend+0xe4/0x170
>     [c000000004eb78d0] [c000000000667bac] ima_add_template_entry+0x1ac/0x350
>     [c000000004eb79b0] [c00000000066ad04] ima_store_template+0xc4/0x150
>     [c000000004eb7a30] [c000000001021a4c] ima_add_boot_aggregate+0xec/0x17c
>     [c000000004eb7b30] [c000000001021b70] ima_init+0x94/0xbc
>     [c000000004eb7b90] [c000000001021ce0] init_ima+0x44/0xec
>     [c000000004eb7c10] [c000000000010694] do_one_initcall+0x64/0x2b0
>     [c000000004eb7ce0] [c000000000fd445c] kernel_init_freeable+0x2e4/0x3cc
>     [c000000004eb7db0] [c000000000010b94] kernel_init+0x2c/0x148
>     [c000000004eb7e20] [c00000000000bc54] ret_from_kernel_thread+0x5c/0x68
>     Instruction dump:
>     90c80002 81410070 714a0001 e9010078 39480002 7d40542c 79470020 4082003c
>     394a0014 7c0a4840 41810090 5546c03e <e87d0000> e89d0008 80bd0010 7d283a14
>     ---[ end trace 786ebab24be797a3 ]---

Attaching the config.

Thanks

Michal

Download attachment "default" of type "application/octet-stream" (178841 bytes)