[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAK8P3a1gunW+R16=GDG+NJ_eaYyiVCDisOa+w5F7tzSGkE2qHQ@mail.gmail.com>
Date: Mon, 1 Jul 2019 17:03:50 +0200
From: Arnd Bergmann <arnd@...db.de>
To: David Miller <davem@...emloft.net>
Cc: Aviad Krawczyk <aviad.krawczyk@...wei.com>, xuechaojing@...wei.com,
Jesse Brandeburg <jesse.brandeburg@...el.com>,
zhaochen6@...wei.com, Eric Dumazet <edumazet@...gle.com>,
Dann Frazier <dann.frazier@...onical.com>,
Networking <netdev@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] hinic: reduce rss_init stack usage
On Fri, Jun 28, 2019 at 6:32 PM David Miller <davem@...emloft.net> wrote:
>
> From: Arnd Bergmann <arnd@...db.de>
> Date: Fri, 28 Jun 2019 12:31:44 +0200
>
> > On 32-bit architectures, putting an array of 256 u32 values on the
> > stack uses more space than the warning limit:
> >
> > drivers/net/ethernet/huawei/hinic/hinic_main.c: In function 'hinic_rss_init':
> > drivers/net/ethernet/huawei/hinic/hinic_main.c:286:1: error: the frame size of 1068 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
> >
> > I considered changing the code to use u8 values here, since that's
> > all the hardware supports, but dynamically allocating the array is
> > a more isolated fix here.
> >
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> Applied to net-next.
Thanks
> Arnd, please make it clear what tree you are targetting in the
> future.
Sorry about missing this again. I usually remember but sometimes
one slips through when I send a lot of patches for different subsystems
at once.
Arnd
Powered by blists - more mailing lists