linux-kernel - Re: [PATCH 12/87] dma: imx-sdma: Remove call to memset after dma_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190701045443.GI2911@vkoul-mobl>
Date:   Mon, 1 Jul 2019 10:24:43 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Fuqian Huang <huangfq.daxian@...il.com>
Cc:     Dan Williams <dan.j.williams@...el.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        dmaengine@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 12/87] dma: imx-sdma: Remove call to memset after
 dma_alloc_coherent

On 28-06-19, 01:35, Fuqian Huang wrote:
>     In commit af7ddd8a627c
> ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
>     dma_alloc_coherent has already zeroed the memory.
>     So memset is not needed.

Please point to the exact commit and not the merge commit. Hint use git
blame on that file...

> 
> Signed-off-by: Fuqian Huang <huangfq.daxian@...il.com>
> ---
>  drivers/dma/imx-sdma.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index 99d9f431ae2c..54d86359bdf8 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -1886,10 +1886,6 @@ static int sdma_init(struct sdma_engine *sdma)
>  	sdma->context_phys = ccb_phys +
>  		MAX_DMA_CHANNELS * sizeof (struct sdma_channel_control);
>  
> -	/* Zero-out the CCB structures array just allocated */
> -	memset(sdma->channel_control, 0,
> -			MAX_DMA_CHANNELS * sizeof (struct sdma_channel_control));
> -
>  	/* disable all channels */
>  	for (i = 0; i < sdma->drvdata->num_events; i++)
>  		writel_relaxed(0, sdma->regs + chnenbl_ofs(sdma, i));
> -- 
> 2.11.0

-- 
~Vinod