linux-kernel - Re: [PATCH v8 4/5] x86/xsave: Make XSAVE check the base CPUID features before enabling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190701164105.GC31027@tassilo.jf.intel.com>
Date:   Mon, 1 Jul 2019 09:41:05 -0700
From:   Andi Kleen <ak@...ux.intel.com>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:     Vegard Nossum <vegard.nossum@...cle.com>,
        Andi Kleen <andi@...stfloor.org>, x86@...nel.org,
        hpa@...or.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 4/5] x86/xsave: Make XSAVE check the base CPUID
 features before enabling

> So if it is unlikely to have XSAVE but no FXSR I would suggest to add
> "fpu__xstate_clear_all_cpu_caps()" to nofxsr and behave like "nofxsr
> noxsave".

Thanks for the analysis Sebastian. Makes sense.

This would likely work, but I think I would rather just remove the option.

-Andi