linux-kernel - Re: [PATCH 1/4] gpu: Use dev_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACvgo525gKG1xok-O-AmTLT4OgupB2FCoO=qeBqS=DXK5vhFOg@mail.gmail.com>
Date:   Mon, 1 Jul 2019 17:56:02 +0100
From:   Emil Velikov <emil.l.velikov@...il.com>
To:     Fuqian Huang <huangfq.daxian@...il.com>
Cc:     David Airlie <airlied@...ux.ie>,
        ML dri-devel <dri-devel@...ts.freedesktop.org>,
        Chandan Uddaraju <chandanu@...eaurora.org>,
        Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
        Jonathan Marek <jonathan@...ek.ca>,
        Sebastian Reichel <sebastian.reichel@...labora.com>,
        Mamta Shukla <mamtashukla555@...il.com>,
        Tomi Valkeinen <tomi.valkeinen@...com>,
        Sibi Sankar <sibis@...eaurora.org>,
        freedreno@...ts.freedesktop.org,
        Rajesh Yadav <ryadav@...eaurora.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Abhinav Kumar <abhinavk@...eaurora.org>,
        Bruce Wang <bzwang@...omium.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Sean Paul <sean@...rly.run>,
        Tomeu Vizoso <tomeu.vizoso@...labora.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
        Daniel Mack <daniel@...que.org>,
        Enrico Weigelt <info@...ux.net>,
        Sravanthi Kollukuduru <skolluku@...eaurora.org>
Subject: Re: [PATCH 1/4] gpu: Use dev_get_drvdata()

On Mon, 1 Jul 2019 at 13:37, Emil Velikov <emil.l.velikov@...il.com> wrote:
>
> Hi Fuqian,
>
> On Mon, 1 Jul 2019 at 08:13, Fuqian Huang <huangfq.daxian@...il.com> wrote:
> >
> > Using dev_get_drvdata directly.
> >
> > Signed-off-by: Fuqian Huang <huangfq.daxian@...il.com>
> > ---
> >  drivers/gpu/drm/msm/adreno/adreno_device.c      |  6 ++----
> >  drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c         | 13 +++++--------
> >  drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c        |  6 ++----
> >  drivers/gpu/drm/msm/dsi/dsi_host.c              |  6 ++----
> >  drivers/gpu/drm/msm/msm_drv.c                   |  3 +--
> >  drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 15 +++++----------
> >  drivers/gpu/drm/panfrost/panfrost_device.c      |  6 ++----
> As far as i can see the patch is spot on, thanks for that.
>
> Can you split this in three since it covers 3 separate drivers.

Quick grep for "platform_get_drvdata(to_platform_device" showed a few
instances through various drivers - exynos, msm, etc.
If you can address those with v2 that would be great.

-Emil