linux-kernel - Re: [PATCH v2] Convert struct pid count to refcount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201907020214.bB70pmmk%lkp@intel.com>
Date:   Tue, 2 Jul 2019 02:46:37 +0800
From:   kbuild test robot <lkp@...el.com>
To:     "Joel Fernandes (Google)" <joel@...lfernandes.org>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org,
        "Joel Fernandes (Google)" <joel@...lfernandes.org>,
        mathieu.desnoyers@...icios.com, willy@...radead.org,
        peterz@...radead.org, will.deacon@....com,
        paulmck@...ux.vnet.ibm.com, elena.reshetova@...el.com,
        keescook@...omium.org, kernel-team@...roid.com,
        kernel-hardening@...ts.openwall.com,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Michal Hocko <mhocko@...e.com>,
        Oleg Nesterov <oleg@...hat.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH v2] Convert struct pid count to refcount_t

Hi "Joel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.2-rc6]
[cannot apply to next-20190625]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Joel-Fernandes-Google/Convert-struct-pid-count-to-refcount_t/20190702-003517
config: riscv-allnoconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=riscv 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> kernel/pid.c:44:30: warning: missing braces around initializer [-Wmissing-braces]
    struct pid init_struct_pid = {
                                 ^
>> kernel/pid.c:44:30: warning: missing braces around initializer [-Wmissing-braces]
>> kernel/pid.c:44:30: warning: missing braces around initializer [-Wmissing-braces]
>> kernel/pid.c:44:30: warning: missing braces around initializer [-Wmissing-braces]
>> kernel/pid.c:44:30: warning: missing braces around initializer [-Wmissing-braces]

vim +44 kernel/pid.c

^1da177e Linus Torvalds 2005-04-16  43  
e1e871af David Howells  2018-01-02 @44  struct pid init_struct_pid = {
e1e871af David Howells  2018-01-02  45  	.count 		= ATOMIC_INIT(1),
e1e871af David Howells  2018-01-02  46  	.tasks		= {
e1e871af David Howells  2018-01-02  47  		{ .first = NULL },
e1e871af David Howells  2018-01-02  48  		{ .first = NULL },
e1e871af David Howells  2018-01-02  49  		{ .first = NULL },
e1e871af David Howells  2018-01-02  50  	},
e1e871af David Howells  2018-01-02  51  	.level		= 0,
e1e871af David Howells  2018-01-02  52  	.numbers	= { {
e1e871af David Howells  2018-01-02  53  		.nr		= 0,
e1e871af David Howells  2018-01-02  54  		.ns		= &init_pid_ns,
e1e871af David Howells  2018-01-02  55  	}, }
e1e871af David Howells  2018-01-02  56  };
^1da177e Linus Torvalds 2005-04-16  57  

:::::: The code at line 44 was first introduced by commit
:::::: e1e871aff3ded26348c631b1370e257d401cd22d Expand INIT_STRUCT_PID and remove

:::::: TO: David Howells <dhowells@...hat.com>
:::::: CC: David Howells <dhowells@...hat.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (5119 bytes)