lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 1 Jul 2019 14:22:27 -0600 From: Jeffrey Hugo <jeffrey.l.hugo@...il.com> To: Rob Clark <robdclark@...il.com> Cc: Sean Paul <sean@...rly.run>, David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>, Bjorn Andersson <bjorn.andersson@...aro.org>, linux-arm-msm <linux-arm-msm@...r.kernel.org>, dri-devel <dri-devel@...ts.freedesktop.org>, freedreno <freedreno@...ts.freedesktop.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] drm/msm/mdp5: Use drm_device for creating gem address space On Mon, Jul 1, 2019 at 1:45 PM Rob Clark <robdclark@...il.com> wrote: > > On Mon, Jul 1, 2019 at 10:39 AM Jeffrey Hugo <jeffrey.l.hugo@...il.com> wrote: > > > > Creating the msm gem address space requires a reference to the dev where > > the iommu is located. The driver currently assumes this is the same as > > the platform device, which breaks when the iommu is outside of the > > platform device. Use the drm_device instead, which happens to always have > > a reference to the proper device. > > > > Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@...il.com> > > --- > > drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > > index 4a60f5fca6b0..1347a5223918 100644 > > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > > @@ -702,7 +702,7 @@ struct msm_kms *mdp5_kms_init(struct drm_device *dev) > > mdelay(16); > > > > if (config->platform.iommu) { > > - aspace = msm_gem_address_space_create(&pdev->dev, > > + aspace = msm_gem_address_space_create(dev->dev, > > config->platform.iommu, "mdp5"); > > hmm, do you have a tree somewhere with your dt files? This makes me > think the display iommu is hooked up somewhere differently compared > to, say, msm8916.dtsi I'll post something somewhere and forward it to you.
Powered by blists - more mailing lists