linux-kernel - Re: [PATCH] soc: ti: fix irq-ti-sci link error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOesGMi5urJPF3cKfF+UB_KrK50_VQw+MMS5w_UqKzEMYKeXFA@mail.gmail.com>
Date:   Mon, 1 Jul 2019 15:24:29 -0700
From:   Olof Johansson <olof@...om.net>
To:     Santosh Shilimkar <santosh.shilimkar@...cle.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Lokesh Vutla <lokeshvutla@...com>,
        Marc Zyngier <marc.zyngier@....com>,
        Tony Lindgren <tony@...mide.com>, Nishanth Menon <nm@...com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux ARM Mailing List <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] soc: ti: fix irq-ti-sci link error

On Mon, Jul 1, 2019 at 10:36 AM <santosh.shilimkar@...cle.com> wrote:
>
> On 6/17/19 6:01 AM, Arnd Bergmann wrote:
> > The irqchip driver depends on the SoC specific driver, but we want
> > to be able to compile-test it elsewhere:
> >
> > WARNING: unmet direct dependencies detected for TI_SCI_INTA_MSI_DOMAIN
> >    Depends on [n]: SOC_TI [=n]
> >    Selected by [y]:
> >    - TI_SCI_INTA_IRQCHIP [=y] && TI_SCI_PROTOCOL [=y]
> >
> > drivers/irqchip/irq-ti-sci-inta.o: In function `ti_sci_inta_irq_domain_probe':
> > irq-ti-sci-inta.c:(.text+0x204): undefined reference to `ti_sci_inta_msi_create_irq_domain'
> >
> > Rearrange the Kconfig and Makefile so we build the soc driver whenever
> > its users are there, regardless of the SOC_TI option.
> >
> > Fixes: 49b323157bf1 ("soc: ti: Add MSI domain bus support for Interrupt Aggregator")
> > Fixes: f011df6179bd ("irqchip/ti-sci-inta: Add msi domain support")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > ---
> Thanks Arnd. Will you be able to add it to your fixes queue.
>
> FWIW, Acked-by: Santosh Shilimkar <ssantosh@...nle.org>

Cc:ing to arm@...nel.org is the best way to make sure it surfaces.

Also, please do Acked-by on separate line so the tools catch it next
time (also, check for typos. :)

Applying to fixes.


-Olof