lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9ba791d5-0d67-9834-90e9-e1dca307d386@kernel.org>
Date:   Tue, 2 Jul 2019 13:25:12 -0600
From:   shuah <shuah@...nel.org>
To:     Andy Lutomirski <luto@...nel.org>,
        Colin King <colin.king@...onical.com>
Cc:     Kees Cook <keescook@...omium.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>, kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>, shuah <shuah@...nel.org>
Subject: Re: [PATCH][next] selftests/x86: fix spelling mistake "FAILT" ->
 "FAIL"

On 7/2/19 8:22 AM, shuah wrote:
> On 7/1/19 11:48 AM, Andy Lutomirski wrote:
>> On Mon, Jul 1, 2019 at 6:04 AM Colin King <colin.king@...onical.com> 
>> wrote:
>>>
>>> From: Colin Ian King <colin.king@...onical.com>
>>>
>>> There is an spelling mistake in an a test error message. Fix it.
>>>
>>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
>>> ---
>>>   tools/testing/selftests/x86/test_vsyscall.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tools/testing/selftests/x86/test_vsyscall.c 
>>> b/tools/testing/selftests/x86/test_vsyscall.c
>>> index 4602326b8f5b..a4f4d4cf22c3 100644
>>> --- a/tools/testing/selftests/x86/test_vsyscall.c
>>> +++ b/tools/testing/selftests/x86/test_vsyscall.c
>>> @@ -451,7 +451,7 @@ static int test_vsys_x(void)
>>>                  printf("[OK]\tExecuting the vsyscall page failed: 
>>> #PF(0x%lx)\n",
>>>                         segv_err);
>>>          } else {
>>> -               printf("[FAILT]\tExecution failed with the wrong 
>>> error: #PF(0x%lx)\n",
>>> +               printf("[FAIL]\tExecution failed with the wrong 
>>> error: #PF(0x%lx)\n",
>>>                         segv_err);
>>>                  return 1;
>>>          }
>>> -- 
>>> 2.20.1
>>>
>>
>> Acked-by: Andy Lutomirski <luto@...nel.org>
>>
> 
> Thanks Andy!
> 
> I will queue this up for 5.3
> 
> -- Shuah
> 

Hi Colin,

Checkpatch warning on this. Probably failed on the original patch.
Could you please fix the checkpatch warn, and send v2.

thanks,
-- Shuah

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ