linux-kernel - Re: [PATCH] fs: btrfs: extent_map: Change return type of unpin_extent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 2 Jul 2019 08:39:41 +0300
From:   Nikolay Borisov <nborisov@...e.com>
To:     Hariprasad Kelam <hariprasad.kelam@...il.com>,
        Chris Mason <clm@...com>, David Sterba <dsterba@...e.com>,
        Josef Bacik <josef@...icpanda.com>,
        linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: btrfs: extent_map: Change return type of
 unpin_extent_cache



On 2.07.19 г. 6:10 ч., Hariprasad Kelam wrote:
> As unpin_extent_cache never fails and Caller does not expect return
> value we can change return value from int to void.
> 
> Issue identified with coccicheck
> fs/btrfs/extent_map.c:284:5-8: Unneeded variable: "ret". Return "0" on
> line 316
> 
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@...il.com>

Reviewed-by: Nikolay Borisov <nborisov@...e.com>