linux-kernel - Re: [PATCH] checkpatch: add *_NOTIFIER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <613b7f1dd7244df22f677777cc946758cbd7e61c.camel@perches.com>
Date:   Tue, 02 Jul 2019 06:11:45 -0700
From:   Joe Perches <joe@...ches.com>
To:     Gilad Ben-Yossef <gilad@...yossef.com>,
        Andy Whitcroft <apw@...onical.com>
Cc:     Ofir Drang <ofir.drang@....com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: add *_NOTIFIER_HEAD as var definition

On Tue, 2019-07-02 at 15:30 +0300, Gilad Ben-Yossef wrote:
> Add *_NOTIFIER_HEAD as variable definition to avoid code like this:
> 
> ATOMIC_NOTIFIER_HEAD(foo);
> EXPORT_SYMBOL_GPL(foo);
> 
> From triggering the the following warning:
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3864,6 +3864,7 @@ sub process {
>  				^.DEFINE_$Ident\(\Q$name\E\)|
>  				^.DECLARE_$Ident\(\Q$name\E\)|
>  				^.LIST_HEAD\(\Q$name\E\)|
> +				^.$Ident._NOTIFIER_HEAD\(\Q$name\E\)|

I think you want "${Ident}_NOTIFIER_HEAD\(\Q$name\E\)

>  				^.(?:$Storage\s+)?$Type\s*\(\s*\*\s*\Q$name\E\s*\)\s*\(|
>  				\b\Q$name\E(?:\s+$Attribute)*\s*(?:;|=|\[|\()
>  			    )/x) {