linux-kernel - Re: [PATCH] nvme: fix multipath crash when ANA deactivated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190702142533.GA16763@lst.de>
Date:   Tue, 2 Jul 2019 16:25:33 +0200
From:   Christoph Hellwig <hch@....de>
To:     Marta Rybczynska <mrybczyn@...ray.eu>
Cc:     Hannes Reinecke <hare@...e.de>, kbusch <kbusch@...nel.org>,
        axboe <axboe@...com>, Christoph Hellwig <hch@....de>,
        Sagi Grimberg <sagi@...mberg.me>,
        linux-nvme <linux-nvme@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Samuel Jones <sjones@...ray.eu>,
        Jean-Baptiste Riaux <jbriaux@...ray.eu>
Subject: Re: [PATCH] nvme: fix multipath crash when ANA deactivated

On Tue, Jul 02, 2019 at 11:52:35AM +0200, Marta Rybczynska wrote:
> > They idea was to use a 'ana_log_buf == NULL' as an indicator that ANA is
> > disabled, so there is no need to have an additional flag.
> 
> OK, still keeping the split of the helper functions?

I think we can simplify switch nvme_ctrl_use_ana to only check for
->ana_log_buf, and just opencode the actual capabilities check in
the setup path.