linux-kernel - Re: [linux-kernel-mentees] [PATCH v5] Doc : fs : convert xfs.txt to ReST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190702151545.GO1404256@magnolia>
Date:   Tue, 2 Jul 2019 08:15:45 -0700
From:   "Darrick J. Wong" <darrick.wong@...cle.com>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     Sheriff Esseson <sheriffesseson@...il.com>,
        skhan@...uxfoundation.org, linux-xfs@...r.kernel.org,
        corbet@....net, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [linux-kernel-mentees] [PATCH v5] Doc : fs : convert xfs.txt to
 ReST

On Tue, Jul 02, 2019 at 08:04:52AM -0700, Matthew Wilcox wrote:
> On Tue, Jul 02, 2019 at 01:30:40PM +0100, Sheriff Esseson wrote:
> > +When mounting an XFS filesystem, the following options are accepted.  For
> > +boolean mount options, the names with the "(*)" prefix is the default behaviour.
> > +For example, take a behaviour enabled by default to be a one (1) or, a zero (0)
> > +otherwise, ``(*)[no]default`` would be 0 while ``[no](*)default`` , a 1.
> > -When mounting an XFS filesystem, the following options are accepted.
> > -For boolean mount options, the names with the (*) suffix is the
> > -default behaviour.
> 
> You seem to have reflowed all the text.  That means git no longer notices
> it's a rename, and quite frankly the shorter lines that were in use were
> better.

Agreed.  Please don't reflow text in a format conversion patch, it makes
it very difficult to figure out which changes were to accomodate rst.

If you want to reflow text (because of line length etc.) please do it as
a second patch.  I'd rather break the 80 column rule for a single commit
if it makes reviewing easy on the eyes.

> This is not an improvement; please undo it in the next version
> (which you should not post for several days to accumulate more feedback).

Seconded.  Thank you for sending v5 as a separate patch, though. :)

--D