linux-kernel - Re: [PATCH 2/3] KVM: nVMX: allow setting the VMFUNC controls MSR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 2 Jul 2019 18:27:49 +0300
From:   Liran Alon <liran.alon@...cle.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH 2/3] KVM: nVMX: allow setting the VMFUNC controls MSR



> On 2 Jul 2019, at 18:04, Paolo Bonzini <pbonzini@...hat.com> wrote:
> 
> Allow userspace to set a custom value for the VMFUNC controls MSR, as long
> as the capabilities it advertises do not exceed those of the host.
> 
> Fixes: 27c42a1bb ("KVM: nVMX: Enable VMFUNC for the L1 hypervisor", 2017-08-03)
> Cc: stable@...r.kernel.org
> Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>

Reviewed-by: Liran Alon <liran.alon@...cle.com>

> ---
> arch/x86/kvm/vmx/nested.c | 5 +++++
> 1 file changed, 5 insertions(+)
> 
> diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c
> index c4e29ef0b21e..163d226efa96 100644
> --- a/arch/x86/kvm/vmx/nested.c
> +++ b/arch/x86/kvm/vmx/nested.c
> @@ -1234,6 +1234,11 @@ int vmx_set_vmx_msr(struct kvm_vcpu *vcpu, u32 msr_index, u64 data)
> 	case MSR_IA32_VMX_VMCS_ENUM:
> 		vmx->nested.msrs.vmcs_enum = data;
> 		return 0;
> +	case MSR_IA32_VMX_VMFUNC:
> +		if (data & ~vmx->nested.msrs.vmfunc_controls)
> +			return -EINVAL;
> +		vmx->nested.msrs.vmfunc_controls = data;
> +		return 0;
> 	default:
> 		/*
> 		 * The rest of the VMX capability MSRs do not support restore.
> -- 
> 1.8.3.1
> 
>