linux-kernel - [PATCH] fs/seq_file: Replace a seq_printf() call by seq_puts() in seq_hex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <8c295901-cdbd-a4a2-f23f-f63a58330f20@web.de>
Date:   Tue, 2 Jul 2019 18:38:27 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     linux-fsdevel@...r.kernel.org,
        Alexander Viro <viro@...iv.linux.org.uk>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: [PATCH] fs/seq_file: Replace a seq_printf() call by seq_puts() in
 seq_hex_dump()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Tue, 2 Jul 2019 18:28:10 +0200

A string which did not contain a data format specification should be put
into a sequence. Thus use the corresponding function “seq_puts”.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 fs/seq_file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/seq_file.c b/fs/seq_file.c
index abe27ec43176..ecc68e9dd31f 100644
--- a/fs/seq_file.c
+++ b/fs/seq_file.c
@@ -868,7 +868,7 @@ void seq_hex_dump(struct seq_file *m, const char *prefix_str, int prefix_type,
 			seq_printf(m, "%s%.8x: ", prefix_str, i);
 			break;
 		default:
-			seq_printf(m, "%s", prefix_str);
+			seq_puts(m, prefix_str);
 			break;
 		}

--
2.22.0