linux-kernel - RE: [PATCH 17/30] pci: Use kmemdup rather than duplicating its implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d185554023eb4de08c366184cceb681f@AcuMS.aculab.com>
Date:   Wed, 3 Jul 2019 16:22:07 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Fuqian Huang' <huangfq.daxian@...il.com>
CC:     Bjorn Helgaas <bhelgaas@...gle.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 17/30] pci: Use kmemdup rather than duplicating its
 implementation

From: Fuqian Huang
> Sent: 03 July 2019 14:16
> 
> kmemdup is introduced to duplicate a region of memory in a neat way.
> Rather than kmalloc/kzalloc + memset, which the programmer needs to
> write the size twice (sometimes lead to mistakes), kmemdup improves
> readability, leads to smaller code and also reduce the chances of mistakes.
> Suggestion to use kmemdup rather than using kmalloc/kzalloc + memset.
> 
> Signed-off-by: Fuqian Huang <huangfq.daxian@...il.com>
> ---
>  drivers/pci/hotplug/ibmphp_core.c | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/pci/hotplug/ibmphp_core.c b/drivers/pci/hotplug/ibmphp_core.c
> index 17124254d897..0e340e105c3b 100644
> --- a/drivers/pci/hotplug/ibmphp_core.c
> +++ b/drivers/pci/hotplug/ibmphp_core.c
> @@ -1261,19 +1261,18 @@ static int __init ibmphp_init(void)
> 
>  	info(DRIVER_DESC " version: " DRIVER_VERSION "\n");
> 
> -	ibmphp_pci_bus = kmalloc(sizeof(*ibmphp_pci_bus), GFP_KERNEL);
> -	if (!ibmphp_pci_bus) {
> -		rc = -ENOMEM;
> -		goto exit;
> -	}
> -
>  	bus = pci_find_bus(0, 0);
>  	if (!bus) {
>  		err("Can't find the root pci bus, can not continue\n");
>  		rc = -ENODEV;
>  		goto error;
>  	}
> -	memcpy(ibmphp_pci_bus, bus, sizeof(*ibmphp_pci_bus));
> +
> +	ibmphp_pci_bus = kmemdup(bus, sizeof(*ibmphp_pci_bus), GFP_KERNEL);
> +	if (!ibmphp_pci_bus) {
> +		rc = -ENOMEM;
> +		goto exit;
> +	}

Not sure why I even looked as this...

But the error path if pci_find_bus() fails is now wrong.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)