linux-kernel - Re: md-multipath: Replace a seq_printf() call by seq_putc() in multipath

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3ae39471-e1d2-2e2a-984a-888340e84447@web.de>
Date:   Wed, 3 Jul 2019 18:28:40 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Song Liu <liu.song.a23@...il.com>,
        linux-raid <linux-raid@...r.kernel.org>
Cc:     Shaohua Li <shli@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: md-multipath: Replace a seq_printf() call by seq_putc() in
 multipath_status()

>> A single character (depending on a condition check) should be put
>> into a sequence. Thus use the corresponding function “seq_putc”.
…
> Can you explain why this is necessary?

I suggest another bit of software fine-tuning.

* Pass only a relevant character instead of a string.

* Omit the format string for a function parameter.

Regards,
Markus