linux-kernel - Re: [PATCH v2 19/35] pcmcia: Use kmemdup rather than duplicating its implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 3 Jul 2019 19:25:17 +0200
From:   Dominik Brodowski <linux@...inikbrodowski.net>
To:     Fuqian Huang <huangfq.daxian@...il.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 19/35] pcmcia: Use kmemdup rather than duplicating its
 implementation

On Thu, Jul 04, 2019 at 12:29:43AM +0800, Fuqian Huang wrote:
> kmemdup is introduced to duplicate a region of memory in a neat way.
> Rather than kmalloc/kzalloc + memcpy, which the programmer needs to
> write the size twice (sometimes lead to mistakes), kmemdup improves
> readability, leads to smaller code and also reduce the chances of mistakes.
> Suggestion to use kmemdup rather than using kmalloc/kzalloc + memcpy.
> 
> Signed-off-by: Fuqian Huang <huangfq.daxian@...il.com>
Acked-by: Dominik Brodowski <linux@...inikbrodowski.net>

Thanks,
	Dominik