linux-kernel - [PATCH] selftests/x86: Don't muck with ftrace in mpx_mini

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <b971a6c04687d4ba1a07bae6c455c2313f91acc0.1562178460.git.luto@kernel.org>
Date:   Wed,  3 Jul 2019 11:28:00 -0700
From:   Andy Lutomirski <luto@...nel.org>
To:     LKML <linux-kernel@...r.kernel.org>
Cc:     x86@...nel.org, Borislav Petkov <bp@...en8.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Andy Lutomirski <luto@...nel.org>,
        Dave Hansen <dave.hansen@...el.com>
Subject: [PATCH] selftests/x86: Don't muck with ftrace in mpx_mini_test

I don't know why mpx_mini_test tries to reprogram ftrace, but it
seems rude and it makes the test crash if run as non-root.  Comment
it out.

Cc: Dave Hansen <dave.hansen@...el.com>
Signed-off-by: Andy Lutomirski <luto@...nel.org>
---
 tools/testing/selftests/x86/mpx-mini-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/x86/mpx-mini-test.c b/tools/testing/selftests/x86/mpx-mini-test.c
index 23ddd453f362..07461ce31d90 100644
--- a/tools/testing/selftests/x86/mpx-mini-test.c
+++ b/tools/testing/selftests/x86/mpx-mini-test.c
@@ -76,9 +76,9 @@ void trace_me(void)
 	write_pid_to("common_pid=", TED "exceptions/filter");
 	write_int_to("", TED "signal/enable", 1);
 	write_int_to("", TED "exceptions/enable", 1);
-*/
 	write_pid_to("", "/sys/kernel/debug/tracing/set_ftrace_pid");
 	write_int_to("", "/sys/kernel/debug/tracing/trace", 0);
+*/
 }
 
 #define test_failed() __test_failed(__FILE__, __LINE__)
-- 
2.21.0