linux-kernel - Re: [PATCH v2 3/3] augmented rbtree: rework the RB_DECLARE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANN689HTCisvT-Pcj9koPZ85b7OY3mOBc8S3X2-eZiVWGhwmqg@mail.gmail.com>
Date:   Tue, 2 Jul 2019 18:12:20 -0700
From:   Michel Lespinasse <walken@...gle.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Davidlohr Bueso <dave@...olabs.net>,
        David Howells <dhowells@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/3] augmented rbtree: rework the RB_DECLARE_CALLBACKS
 macro definition

On Tue, Jul 2, 2019 at 4:52 AM Peter Zijlstra <peterz@...radead.org> wrote:
> > - Reorder the RB_DECLARE_CALLBACKS macro arguments, following the
> >   style of the INTERVAL_TREE_DEFINE macro, so that RBSTATIC and RBNAME
> >   are passed last.
>
> That's, IMO, a weird change. C has storage type and name first, why
> would you want to put that last. If anything, change
> INTERVAL_TREE_DEFINE().

Makes sense, will do. I'll have to make it a v3 of the patchset
because RB_DECLARE_CALLBACKS_MAX was introduced with the opposite
argument order. Oh well, no big deal.

-- 
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.