linux-kernel - Re: [PATCH] Revert "x86/build: Move

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201907011450.100092F32@keescook>
Date:   Mon, 1 Jul 2019 14:51:30 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Ingo Molnar <mingo@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Borislav Petkov <bp@...en8.de>
Cc:     linux-kernel@...r.kernel.org, Ross Zwisler <zwisler@...gle.com>,
        Ross Zwisler <zwisler@...omium.org>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Johannes Hirte <johannes.hirte@...enkhaos.de>,
        Klaus Kusche <klaus.kusche@...puterix.info>,
        samitolvanen@...gle.com, Guenter Roeck <groeck@...gle.com>
Subject: Re: [PATCH] Revert "x86/build: Move _etext to actual end of .text"

On Mon, Jul 01, 2019 at 09:52:08AM -0600, Ross Zwisler wrote:
> This reverts commit 392bef709659abea614abfe53cf228e7a59876a4.
> 
> Per the discussion here:
> 
> https://lkml.org/lkml/2019/6/20/830
> 
> the above referenced commit breaks kernel compilation with old GCC
> toolchains as well as current versions of the Gold linker.  Revert it so
> we don't regress and lose the ability to compile the kernel with these
> tools.
> 
> Signed-off-by: Ross Zwisler <zwisler@...gle.com>

Acked-by: Kees Cook <keescook@...omium.org>

-Kees

> ---
>  arch/x86/kernel/vmlinux.lds.S | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
> index 0850b5149345..4d1517022a14 100644
> --- a/arch/x86/kernel/vmlinux.lds.S
> +++ b/arch/x86/kernel/vmlinux.lds.S
> @@ -141,10 +141,10 @@ SECTIONS
>  		*(.text.__x86.indirect_thunk)
>  		__indirect_thunk_end = .;
>  #endif
> -	} :text = 0x9090
>  
> -	/* End of text section */
> -	_etext = .;
> +		/* End of text section */
> +		_etext = .;
> +	} :text = 0x9090
>  
>  	NOTES :text :note
>  
> -- 
> 2.20.1

-- 
Kees Cook