linux-kernel - Re: [PATCHv2] selftests/net: skip psock_tpacket test if KALLSYMS was not enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190702.201805.1617924578071148532.davem@davemloft.net>
Date:   Tue, 02 Jul 2019 20:18:05 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     po-hsu.lin@...onical.com
Cc:     shuah@...nel.org, linux-kselftest@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2] selftests/net: skip psock_tpacket test if KALLSYMS
 was not enabled

From: Po-Hsu Lin <po-hsu.lin@...onical.com>
Date: Mon,  1 Jul 2019 12:40:31 +0800

> The psock_tpacket test will need to access /proc/kallsyms, this would
> require the kernel config CONFIG_KALLSYMS to be enabled first.
> 
> Apart from adding CONFIG_KALLSYMS to the net/config file here, check the
> file existence to determine if we can run this test will be helpful to
> avoid a false-positive test result when testing it directly with the
> following commad against a kernel that have CONFIG_KALLSYMS disabled:
>     make -C tools/testing/selftests TARGETS=net run_tests
> 
> Signed-off-by: Po-Hsu Lin <po-hsu.lin@...onical.com>

Applied, thank you.