linux-kernel - Re: [PATCH -next] btrfs: remove set but not used variable 'offset'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <98cd6f89-80f2-ee2c-aa07-6e06e424e79f@oracle.com>
Date:   Wed, 3 Jul 2019 11:51:41 +0800
From:   Anand Jain <anand.jain@...cle.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     nborisov@...e.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] btrfs: remove set but not used variable 'offset'

On 2/7/19 10:15 PM, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> fs/btrfs/volumes.c: In function __btrfs_map_block:
> fs/btrfs/volumes.c:6023:6: warning:
>   variable offset set but not used [-Wunused-but-set-variable]
> 
> It is not used any more since commit 343abd1c0ca9 ("btrfs: Use
> btrfs_get_io_geometry appropriately")
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>


Reviewed-by: Anand Jain <anand.jain@...cle.com>


> ---
>   fs/btrfs/volumes.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index d1fd910..5d5a9ff 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -6020,7 +6020,6 @@ static int __btrfs_map_block(struct btrfs_fs_info *fs_info,
>   {
>   	struct extent_map *em;
>   	struct map_lookup *map;
> -	u64 offset;
>   	u64 stripe_offset;
>   	u64 stripe_nr;
>   	u64 stripe_len;
> @@ -6055,7 +6054,6 @@ static int __btrfs_map_block(struct btrfs_fs_info *fs_info,
>   	map = em->map_lookup;
>   
>   	*length = geom.len;
> -	offset = geom.offset;
>   	stripe_len = geom.stripe_len;
>   	stripe_nr = geom.stripe_nr;
>   	stripe_offset = geom.stripe_offset;
>