lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 3 Jul 2019 01:37:26 +0200 From: Martin Blumenstingl <martin.blumenstingl@...glemail.com> To: Rob Herring <robh+dt@...nel.org> Cc: linux-mips@...r.kernel.org, devicetree@...r.kernel.org, John Crispin <john@...ozen.org>, Kishon Vijay Abraham I <kishon@...com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Hauke Mehrtens <hauke@...ke-m.de>, Paul Burton <paul.burton@...s.com>, Ralf Baechle <ralf@...ux-mips.org>, Mark Rutland <mark.rutland@....com>, Martin Schiller <ms@....tdt.de> Subject: Re: [PATCH 1/4] dt-bindings: phy: add binding for the Lantiq VRX200 and ARX300 PCIe PHYs Hi Rob, On Wed, Jul 3, 2019 at 1:34 AM Rob Herring <robh+dt@...nel.org> wrote: [...] > > + lantiq,rcu: > > + maxItems: 1 > > + description: phandle to the RCU syscon > > You need to define the type (and drop maxItems): > > $ref: /schemas/types.yaml#/definitions/phandle thank you for this hint - the examples I used didn't have it > > + > > + lantiq,rcu-endian-offset: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: the offset of the endian registers for this PHY instance in the RCU syscon > > + > > + lantiq,rcu-big-endian-mask: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: the mask to set the PDI (PHY) registers for this PHY instance to big endian > > + > > +required: > > + - "#phy-cells" > > + - compatible > > + - reg > > + - clocks > > + - clock-names > > + - resets > > + - reset-names > > + - lantiq,rcu > > + - lantiq,rcu-endian-offset > > + - lantiq,rcu-big-endian-mask > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + pcie0_phy: phy@...800 { > > + compatible = "lantiq,vrx200-pcie-phy"; > > + reg = <0x106800 0x100>; > > + lantiq,rcu = <&rcu0>; > > + lantiq,rcu-endian-offset = <0x4c>; > > + lantiq,rcu-big-endian-mask = <0x80>; /* bit 7 */ > > + big-endian; > > The example will fail to validate because big-endian is not listed as > a property and you have 'additionalProperties: false'. So you have to > either list big-endian or drop additionalProperties. good catch, thank you. I'll add big-endian and little-endian as allowed (but optional) properties > Note that the examples are validated against the schema in linux-next now. I tested this with yesterday's linux-next tree and it didn't fail for me do you have any hint how I can run this validation myself? Martin
Powered by blists - more mailing lists