[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CACRpkdbcgaNmWkHJpj9bt4bFu+RtWSAtUjwkNDpJj6VsJGyTrw@mail.gmail.com>
Date: Wed, 3 Jul 2019 10:09:44 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Arnd Bergmann <arnd@...db.de>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Enrico Weigelt <info@...ux.net>,
"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
Ulf Hansson <ulf.hansson@...aro.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Andy Shevchenko <andy.shevchenko@...il.com>,
Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] devres: allow const resource arguments
On Fri, Jun 28, 2019 at 5:00 PM Arnd Bergmann <arnd@...db.de> wrote:
> devm_ioremap_resource() does not currently take 'const' arguments,
> which results in a warning from the first driver trying to do it
> anyway:
>
> drivers/gpio/gpio-amd-fch.c: In function 'amd_fch_gpio_probe':
> drivers/gpio/gpio-amd-fch.c:171:49: error: passing argument 2 of 'devm_ioremap_resource' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
> priv->base = devm_ioremap_resource(&pdev->dev, &amd_fch_gpio_iores);
> ^~~~~~~~~~~~~~~~~~~
>
> Change the prototype to allow it, as there is no real reason not to.
>
> Fixes: 9bb2e0452508 ("gpio: amd: Make resource struct const")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
Patch applied with Greg's and Enrico's ACKs.
Yours,
Linus Walleij
Powered by blists - more mailing lists