linux-kernel - Re: [PATCH] NFS: Less function calls in show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ed599239-a6a2-1cc6-14ce-d5bb41e9170f@web.de>
Date:   Wed, 3 Jul 2019 10:48:26 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Julia Lawall <julia.lawall@...6.fr>, linux-nfs@...r.kernel.org
Cc:     Anna Schumaker <anna.schumaker@...app.com>,
        Trond Myklebust <trond.myklebust@...merspace.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] NFS: Less function calls in show_pnfs()

>> +++ b/fs/nfs/super.c
>> @@ -749,11 +749,10 @@ static void show_sessions(struct seq_file *m, struct nfs_server *server) {}
>>  #ifdef CONFIG_NFS_V4_1
>>  static void show_pnfs(struct seq_file *m, struct nfs_server *server)
>>  {
>> -	seq_printf(m, ",pnfs=");
>> -	if (server->pnfs_curr_ld)
>> -		seq_printf(m, "%s", server->pnfs_curr_ld->name);
>> -	else
>> -		seq_printf(m, "not configured");
>> +	seq_printf(m, ",pnfs=%s",
>> +		   server->pnfs_curr_ld
>> +		   ? server->pnfs_curr_ld->name
>> +		   : "not configured");
>
> Unreadable.

* Do you find any other source code formatting more readable
  for the usage of the ternary operator?

* How do you think about the general software transformation possibility
  (at this place)?

Regards,
Markus