linux-kernel - Re: fs/seq_file: Replace a seq_printf() call by seq_puts() in seq_hex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f62fdb13-59b7-4e5d-b64a-37b96b5c0125@web.de>
Date:   Wed, 3 Jul 2019 13:01:30 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Enrico Weigelt <lkml@...ux.net>, linux-fsdevel@...r.kernel.org
Cc:     Alexander Viro <viro@...iv.linux.org.uk>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: fs/seq_file: Replace a seq_printf() call by seq_puts() in
 seq_hex_dump()

> Looks good,

Thanks for your feedback.

> but have you checked whether "m" could ever be NULL

I wonder about this enquiry.

This function parameter should be valid as usual.
Thus it should not be a null pointer under ordinary conditions.

> and whether seq_puts() has a check for that ?

These output functions do not provide an explicit sanity check for their first parameter
so far.

Regards,
Markus