linux-kernel - Re: [PATCH 1/3] x86/paravirt: Make read_cr2() CALLEE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53806e4a-f905-a4db-f18c-f747a7ad0e81@suse.com>
Date:   Wed, 3 Jul 2019 16:12:57 +0200
From:   Juergen Gross <jgross@...e.com>
To:     root <peterz@...radead.org>, bp@...en8.de, rostedt@...dmis.org,
        luto@...nel.org, mingo@...nel.org, tglx@...utronix.de,
        torvalds@...ux-foundation.org
Cc:     devel@...ukata.com, joel@...lfernandes.org,
        dave.hansen@...ux.intel.com, linux-kernel@...r.kernel.org,
        zhe.he@...driver.com, hpa@...or.com
Subject: Re: [PATCH 1/3] x86/paravirt: Make read_cr2() CALLEE_SAVE

On 03.07.19 12:27, root wrote:
> The one paravirt read_cr2() implementation (Xen) is actually quite
> trivial and doesn't need to clobber anything other than the return
> register. By making read_cr2() CALLEE_SAVE we avoid all the PUSH/POP
> nonsense and allow more convenient use from assembly.
> 
> Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>

Reviewed-by: Juergen Gross <jgross@...e.com>


Juergen