lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 3 Jul 2019 16:18:46 +0200 From: Michal Kubecek <mkubecek@...e.cz> To: netdev@...r.kernel.org Cc: Johannes Berg <johannes@...solutions.net>, David Miller <davem@...emloft.net>, Jakub Kicinski <jakub.kicinski@...ronome.com>, Jiri Pirko <jiri@...nulli.us>, Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>, John Linville <linville@...driver.com>, Stephen Hemminger <stephen@...workplumber.org>, linux-kernel@...r.kernel.org Subject: Re: [PATCH net-next v6 07/15] ethtool: support for netlink notifications On Wed, Jul 03, 2019 at 03:39:54PM +0200, Johannes Berg wrote: > On Tue, 2019-07-02 at 13:50 +0200, Michal Kubecek wrote: > > > > +static bool ethnl_ok __read_mostly; > > Not sure it makes a big difference, but it could probably be > __ro_after_init instead? Yes, that's more fitting; the flag is initialized to false, changes to true once ethtool netlink is ready and never changes back. I wasn't aware of __ro_after_init annotation. Michal
Powered by blists - more mailing lists