linux-kernel - Re: [PATCH] crypto: cryptd - Fix skcipher instance memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190703142954.pxvp3hcvnff3cg3o@gondor.apana.org.au>
Date:   Wed, 3 Jul 2019 22:29:54 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Vincent Whitchurch <vincent.whitchurch@...s.com>
Cc:     davem@...emloft.net, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, rabinv@...s.com
Subject: Re: [PATCH] crypto: cryptd - Fix skcipher instance memory leak

Vincent Whitchurch <vincent.whitchurch@...s.com> wrote:
> cryptd_skcipher_free() fails to free the struct skcipher_instance
> allocated in cryptd_create_skcipher(), leading to a memory leak.  This
> is detected by kmemleak on bootup on ARM64 platforms:
> 
> unreferenced object 0xffff80003377b180 (size 1024):
>   comm "cryptomgr_probe", pid 822, jiffies 4294894830 (age 52.760s)
>   backtrace:
>     kmem_cache_alloc_trace+0x270/0x2d0
>     cryptd_create+0x990/0x124c
>     cryptomgr_probe+0x5c/0x1e8
>     kthread+0x258/0x318
>     ret_from_fork+0x10/0x1c
> 
> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@...s.com>
> ---
> crypto/cryptd.c | 1 +
> 1 file changed, 1 insertion(+)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt