linux-kernel - Re: [PATCH v3] mm/z3fold.c: Lock z3fold page before _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALvZod7udORRrz7wzQPRa2Eya5TfrVh9kG037GKsAsSkRJPx7Q@mail.gmail.com>
Date:   Tue, 2 Jul 2019 17:59:03 -0700
From:   Shakeel Butt <shakeelb@...gle.com>
To:     Henry Burns <henryburns@...gle.com>
Cc:     Vitaly Wool <vitalywool@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Vitaly Vul <vitaly.vul@...y.com>,
        Mike Rapoport <rppt@...ux.vnet.ibm.com>,
        Xidong Wang <wangxidong_97@....com>,
        Jonathan Adams <jwadams@...gle.com>,
        Linux MM <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>,
        David Rientjes <rientjes@...gle.com>, stable@...r.kernel.org
Subject: Re: [PATCH v3] mm/z3fold.c: Lock z3fold page before __SetPageMovable()

On Tue, Jul 2, 2019 at 4:35 PM Henry Burns <henryburns@...gle.com> wrote:
>
> Following zsmalloc.c's example we call trylock_page() and unlock_page().
> Also make z3fold_page_migrate() assert that newpage is passed in locked,
> as per the documentation.
>
> Link: http://lkml.kernel.org/r/20190702005122.41036-1-henryburns@google.com
> Signed-off-by: Henry Burns <henryburns@...gle.com>
> Suggested-by: Vitaly Wool <vitalywool@...il.com>
> Acked-by: Vitaly Wool <vitalywool@...il.com>
> Acked-by: David Rientjes <rientjes@...gle.com>
> Cc: Shakeel Butt <shakeelb@...gle.com>
> Cc: Vitaly Vul <vitaly.vul@...y.com>
> Cc: Mike Rapoport <rppt@...ux.vnet.ibm.com>
> Cc: Xidong Wang <wangxidong_97@....com>
> Cc: Jonathan Adams <jwadams@...gle.com>
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>

We need a "Fixes" tag.

Reviewed-by: Shakeel Butt <shakeelb@...gle.com>