linux-kernel - Re: [GIT PULL 3/4] intel_th: msu: Fix single mode with disabled IOMMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190703153619.GB22834@kroah.com>
Date:   Wed, 3 Jul 2019 17:36:19 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Cc:     linux-kernel@...r.kernel.org,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Ammy Yi <ammy.yi@...el.com>
Subject: Re: [GIT PULL 3/4] intel_th: msu: Fix single mode with disabled IOMMU

On Fri, Jun 21, 2019 at 07:19:29PM +0300, Alexander Shishkin wrote:
> Commit 4e0eaf239fb3 ("intel_th: msu: Fix single mode with IOMMU") switched
> the single mode code to use dma mapping pages obtained from the page
> allocator, but with IOMMU disabled, that may lead to using SWIOTLB bounce
> buffers and without additional sync'ing, produces empty trace buffers.
> 
> Fix this by using a DMA32 GFP flag to the page allocation in single mode,
> as the device supports full 32-bit DMA addressing.
> 
> Signed-off-by: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
> Fixes: 4e0eaf239fb3 ("intel_th: msu: Fix single mode with IOMMU")
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Reported-by: Ammy Yi <ammy.yi@...el.com>
> ---
>  drivers/hwtracing/intel_th/msu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

You should have had a stable tag on here anyway...